Fix degenerate MultiPolygon centroids - #7921
Merged
camdecoster merged 5 commits intoJul 31, 2026
Merged
Conversation
swjturay
marked this pull request as ready for review
July 26, 2026 13:01
Contributor
|
Thanks for the PR! I'll take a look and follow up. |
camdecoster
approved these changes
Jul 31, 2026
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix! Your solution was spot on. While reviewing, I noticed another potential failure mode where polygon rings could have no points in the array so I added a guard against that as well (along with some more tests). I also added some logging similar to what we already do for invalid GeoJSON geometry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #7874.
Prevent a zero-area
MultiPolygonfeature from aborting choropleth rendering. When centroid selection cannot find a positive-area sub-polygon, the feature now receives the existing[NaN, NaN]centroid sentinel. Its geometry remains available for rendering, while valid sibling features continue through extraction.Root cause and user impact
The
MultiPolygoncentroid path initializedmaxAreato zero and only selected sub-polygons whose area was strictly greater. If every sub-polygon had zero area, the selected polygon remained undefined and was passed to Turf's centroid helper, causing an uncaughtTypeErrorthat stopped the entire plot.The guard is limited to that no-positive-area case. Centroid calculation for valid
PolygonandMultiPolygonfeatures is unchanged.Validation
Cannot read properties of undefined (reading 'type').npm run test-jasmine -- lib_geo_location_utils choropleth --nowatch --report-spec— 37/37 passed (Chromium-based Edge viaCHROME_BIN).npm run test-syntaxnpm run lintgit diff --check